Files
portal/app/tests/Feature/Plan5/Projects/ProjectsUpdateTest.php
T
Дмитрий 88ace4e3d9
Accessibility (Pa11y live) / a11y (push) Has been cancelled
test: дозакрытие оздоровления — protekateli pd-аудита, видимость supplier, новый флоу регистрации
Снижение остатка 19 to 5. Всё тест-сторона:
- PdErasureServiceTest + AdminPdSubjectRequestsControllerTest: SharesSupplierPdo —
  перестали коммитить pd_processing_log через pgsql_supplier, что ломало
  глобальный audit:verify-chains (6 падений) и амплифицировало PhoneRegionSmoke.
- ReportFileDeletePdLogTest: SharesSupplierPdo — cron reports:cleanup-expired
  теперь видит незакоммиченные job'ы теста.
- AdminSuppliersControllerTest: устойчивый ассерт (с фазы 3 в suppliers есть direct).
- AuthLogCoverageTest/AuthFlowIntegrationTest: новый флоу самозаписи G1/SP1 —
  register_success пишется после confirm-email; добавлен шаг подтверждения.
- ImpersonationTest end: verify (G7-B) ставит маркер impersonation → admin-зона
  закрыта by design; помечаем токен used напрямую вместо session-takeover.
- CleanupInactiveSupplierProjectsJobTest: phase A читает pivot project_supplier_links —
  добавлена привязка linkProjectToSupplier (раньше был только legacy FK).
- Pint-нормализация uses() FQN to import в ранее тронутых файлах.

Остаток 5 (НЕ слепой патч): webhook B-префикс ×2 (решение владельца), advisory-lock
audit-цепочки (возможный дрейф схемы, флажок), SupplierConnection WARN#2 (cap-3,
поведенческое), SupplierPortalClientTest (пре-существующий, не от этих правок).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
2026-06-25 08:19:53 +03:00

220 lines
8.7 KiB
PHP

<?php
declare(strict_types=1);
use App\Jobs\SyncSupplierProjectJob;
use App\Models\Project;
use App\Models\Tenant;
use App\Models\User;
use Illuminate\Foundation\Testing\DatabaseTransactions;
use Illuminate\Support\Facades\Queue;
uses(DatabaseTransactions::class);
beforeEach(fn () => Queue::fake());
it('updates name without resync (name is local-only)', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create([
'tenant_id' => $tenant->id, 'signal_type' => 'site',
'signal_identifier' => 'a.ru', 'daily_limit_target' => 10,
]);
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'name' => 'New name',
])->assertOk();
expect($project->fresh()->name)->toBe('New name');
Queue::assertNotPushed(SyncSupplierProjectJob::class);
});
it('changing daily_limit_target triggers resync (poster must see new limit immediately)', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create([
'tenant_id' => $tenant->id, 'signal_type' => 'site',
'signal_identifier' => 'a.ru', 'daily_limit_target' => 10,
]);
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'daily_limit_target' => 50,
])->assertOk();
expect($project->fresh()->daily_limit_target)->toBe(50);
Queue::assertPushed(SyncSupplierProjectJob::class);
});
it('changing delivery_days_mask triggers resync (poster must see new days immediately)', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create([
'tenant_id' => $tenant->id, 'signal_type' => 'site',
'signal_identifier' => 'a.ru', 'delivery_days_mask' => 31,
]);
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'delivery_days_mask' => 63, // +Сб
])->assertOk();
expect($project->fresh()->delivery_days_mask)->toBe(63);
Queue::assertPushed(SyncSupplierProjectJob::class);
});
it('changing sms_senders triggers resync', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create([
'tenant_id' => $tenant->id, 'signal_type' => 'sms',
'sms_senders' => ['OLD'], 'sms_keyword' => 'x',
]);
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'sms_senders' => ['NEW'],
])->assertOk();
Queue::assertPushed(SyncSupplierProjectJob::class);
});
it('rejects daily_limit_target below delivered_today', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create([
'tenant_id' => $tenant->id, 'daily_limit_target' => 50, 'delivered_today' => 30,
]);
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'daily_limit_target' => 20,
])->assertStatus(422);
});
it('rejects update of signal_type (immutable)', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create(['tenant_id' => $tenant->id, 'signal_type' => 'site', 'signal_identifier' => 'test.ru']);
$response = $this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'signal_type' => 'call',
]);
// signal_type должен быть проигнорирован (не падает 422, но и не меняется)
expect($project->fresh()->signal_type)->toBe('site');
});
it('cross-tenant update returns 404', function () {
$tenantA = Tenant::factory()->create();
$tenantB = Tenant::factory()->create();
$userA = User::factory()->create(['tenant_id' => $tenantA->id]);
$project = Project::factory()->create(['tenant_id' => $tenantB->id]);
$this->actingAs($userA)->patchJson("/api/projects/{$project->id}", [
'name' => 'hack',
])->assertStatus(404);
});
it('updates delivery_days_mask (region_mask now read-only — see regions[] tests below)', function () {
// Plan 6: region_mask/region_mode больше не клиент-controllable через UpdateProjectRequest
// (validation rules удалены, ProjectService::create dual-writes 255/include).
// Источник истины для региональной фильтрации — projects.regions INT[] (Plan 6).
// Этот тест адаптирован: проверяет, что delivery_days_mask остаётся writeable через PATCH.
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create(['tenant_id' => $tenant->id]);
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'delivery_days_mask' => 31,
])->assertOk();
expect($project->fresh()->delivery_days_mask)->toBe(31);
});
// Plan 6 — subject-level regions[] support.
it('updates regions array via PATCH', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create(['tenant_id' => $tenant->id, 'regions' => []]);
$response = $this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'regions' => [82],
]);
$response->assertStatus(200);
$response->assertJsonPath('data.regions', [82]);
expect($project->fresh()->regions)->toBe([82]);
});
it('preserves regions when PATCH omits the field (sometimes rule)', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create([
'tenant_id' => $tenant->id,
'regions' => [82, 83],
]);
$response = $this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'name' => 'Renamed Project',
]);
$response->assertStatus(200);
expect($project->fresh()->regions)->toBe([82, 83]);
});
/* ---------------------------------------------------------------------
* 18.05.2026 UX-request (Task 5 плана): редактирование источника
* (signal_identifier для site/call) — Sync поставщику обязателен.
* --------------------------------------------------------------------- */
it('updates signal_identifier for site project + triggers resync', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create([
'tenant_id' => $tenant->id, 'signal_type' => 'site', 'signal_identifier' => 'old.ru',
]);
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'signal_identifier' => 'new-source.ru',
])->assertOk();
expect($project->fresh()->signal_identifier)->toBe('new-source.ru');
Queue::assertPushed(SyncSupplierProjectJob::class);
});
it('updates signal_identifier for call project (11-digit phone)', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create([
'tenant_id' => $tenant->id, 'signal_type' => 'call', 'signal_identifier' => '79991111111',
]);
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'signal_identifier' => '79992222222',
])->assertOk();
expect($project->fresh()->signal_identifier)->toBe('79992222222');
});
it('rejects invalid signal_identifier for site (not a domain)', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create([
'tenant_id' => $tenant->id, 'signal_type' => 'site', 'signal_identifier' => 'ok.ru',
]);
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'signal_identifier' => 'not-a-domain',
])->assertStatus(422)->assertJsonValidationErrors(['signal_identifier']);
});
it('rejects invalid signal_identifier for call (not 7\d{10})', function () {
$tenant = Tenant::factory()->create();
$user = User::factory()->create(['tenant_id' => $tenant->id]);
$project = Project::factory()->create([
'tenant_id' => $tenant->id, 'signal_type' => 'call', 'signal_identifier' => '79991111111',
]);
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
'signal_identifier' => '12345',
])->assertStatus(422)->assertJsonValidationErrors(['signal_identifier']);
});