Files
portal/app/tests/Unit/Supplier/RefreshSupplierSessionJobTest.php
T
Дмитрий c52d42d447 fix(supplier): Plan 3 final review C-1 + I-2 — TestCase autowire + lock TTL
C-1: PlaywrightBridgeTest + RefreshSupplierSessionJobTest swap line order
- uses(TestCase::class) was BEFORE use Tests\TestCase → Pest resolved to
  non-existent \TestCase → file-load fatal → 6 tests NEVER ran since 71c999b.
- Fix: import BEFORE uses() call (pattern matches 3 working files в same dir).
- Misdiagnosis correction: ранее "pao stream_filter" symptoms attributed to
  laravel/pao env quirk были фактически C-1. Full suite parallel:
  617 tests / 614 passed / 3 skipped / 0 failed.

I-2: RefreshSupplierSessionJob lock TTL bump 30s → 90s
- PlaywrightBridge::TIMEOUT_SECONDS=75s. Lock TTL 30s → auto-expiry while
  real chromium boot+login still в процессе → concurrent refresh race.
- Fix: lock(name, 90)->block(95, ...) — exceeds PlaywrightBridge timeout.

Baseline regenerated после C-1 fix (stale entries removed, fresh Mockery
type errors captured).

Verification:
- tests/Unit/Supplier/: 30/30 pass (was 22/30 — 6 не запускались, 2 skip)
- Full parallel suite: 617/614+3 skipped/0 failed
- PHPStan: 0 errors. Pint: clean.

Final code-review (subagent verdict pre-C-1): "Ready to merge, with C-1 fix".
После этого commit'а — verdict satisfied.

Issues defer-to-post-merge per reviewer (follow-up tracking в memory):
- I-1 onOneServer (multi-server scaling; gated на Б-1 production)
- I-3 save_orphan recovery path (rare DB-write fail during HTTP success)
- I-4 region_mode='exclude' regions_reverse passthrough
- I-5 #4 acceptance criterion deferred until Task 1 closes
2026-05-11 06:51:22 +03:00

61 lines
2.1 KiB
PHP

<?php
declare(strict_types=1);
use App\Exceptions\Supplier\SupplierAuthException;
use App\Jobs\Supplier\RefreshSupplierSessionJob;
use App\Services\Supplier\PlaywrightBridge;
use Illuminate\Support\Facades\Cache;
use Tests\TestCase;
uses(TestCase::class);
beforeEach(function () {
config([
'services.supplier.login' => 'test_login',
'services.supplier.password' => 'test_password',
'services.supplier.portal_url' => 'https://crm.bp-gr.ru',
]);
Cache::store('redis')->forget('supplier:session');
});
afterEach(function () {
Cache::store('redis')->forget('supplier:session');
Mockery::close();
});
test('writes session data to Redis cache key supplier:session with 6h TTL', function () {
$bridge = Mockery::mock(PlaywrightBridge::class);
/** @var PlaywrightBridge $bridge */
$bridge->shouldReceive('refreshSession')
->once()
->with('test_login', 'test_password', 'https://crm.bp-gr.ru')
->andReturn([
'phpsessid' => 'sess123',
'csrf' => 'csrf456',
'refreshed_at' => '2026-05-11T10:00:00Z',
]);
(new RefreshSupplierSessionJob)->handle($bridge);
$cached = Cache::store('redis')->get('supplier:session');
expect($cached)->toBeArray()
->and($cached['phpsessid'])->toBe('sess123')
->and($cached['csrf'])->toBe('csrf456')
->and($cached['refreshed_at'])->toBe('2026-05-11T10:00:00Z');
});
test('rethrows SupplierAuthException from PlaywrightBridge', function () {
$bridge = Mockery::mock(PlaywrightBridge::class);
/** @var PlaywrightBridge $bridge */
$bridge->shouldReceive('refreshSession')
->andThrow(new SupplierAuthException('Login rejected'));
expect(fn () => (new RefreshSupplierSessionJob)->handle($bridge))
->toThrow(SupplierAuthException::class);
});
// NOTE: artisan() command test moved to tests/Feature/Supplier/SupplierSessionRefreshCommandTest.php
// (Pest Unit/ + $this->artisan() + uses(TestCase::class) триггерит laravel/pao stream_filter
// conflict при кросс-файловом запуске tests/Unit/Supplier/).