Дмитрий
c1ecefafc0
- Project model: +regions in fillable + cast via PostgresIntArray
(custom Eloquent cast for PG INT[] — Laravel stock 'array' uses JSON
which Postgres rejects on native INT[] columns)
- StoreProjectRequest / UpdateProjectRequest: drop region_mask/mode rules,
add regions array validation (1..89 each, present/sometimes)
- ProjectService::create: dual-write — regions источник истины + legacy
region_mask=255 + region_mode='include' для PhonePrefixService/LeadRouter
compatibility (Plan 6.5 cleanup will remove dual-write)
- +5 Pest tests covering create/update/dual-write/validation rejection
- Drive-by: SchemaDeltaTest indexes pin 117 → 118 (Plan 6 v8.20 carryover
from Task 1; should ideally have landed in Task 1 commit c487641)
- phpstan-baseline: +3 entries for Project::$regions until next ide-helper
regen; existing Pest actingAs counts bumped 9→12 / 6→8 for new tests
Verified: Pest --parallel 747/744/3sk/0/0 (5 new tests pass +
SchemaDeltaTest now green), phpstan 0 errors, pint clean, gitleaks 0.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
127 lines
4.8 KiB
PHP
127 lines
4.8 KiB
PHP
<?php
|
|
|
|
declare(strict_types=1);
|
|
|
|
use App\Jobs\SyncSupplierProjectJob;
|
|
use App\Models\Project;
|
|
use App\Models\Tenant;
|
|
use App\Models\User;
|
|
use Illuminate\Support\Facades\Queue;
|
|
|
|
beforeEach(fn () => Queue::fake());
|
|
|
|
it('updates name+daily_limit without resync', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$user = User::factory()->create(['tenant_id' => $tenant->id]);
|
|
$project = Project::factory()->create([
|
|
'tenant_id' => $tenant->id, 'signal_type' => 'site',
|
|
'signal_identifier' => 'a.ru', 'daily_limit_target' => 10,
|
|
]);
|
|
|
|
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
|
|
'name' => 'New name', 'daily_limit_target' => 50,
|
|
])->assertOk();
|
|
|
|
expect($project->fresh()->name)->toBe('New name');
|
|
expect($project->fresh()->daily_limit_target)->toBe(50);
|
|
Queue::assertNotPushed(SyncSupplierProjectJob::class);
|
|
});
|
|
|
|
it('changing sms_senders triggers resync', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$user = User::factory()->create(['tenant_id' => $tenant->id]);
|
|
$project = Project::factory()->create([
|
|
'tenant_id' => $tenant->id, 'signal_type' => 'sms',
|
|
'sms_senders' => ['OLD'], 'sms_keyword' => 'x',
|
|
]);
|
|
|
|
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
|
|
'sms_senders' => ['NEW'],
|
|
])->assertOk();
|
|
|
|
Queue::assertPushed(SyncSupplierProjectJob::class);
|
|
});
|
|
|
|
it('rejects daily_limit_target below delivered_today', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$user = User::factory()->create(['tenant_id' => $tenant->id]);
|
|
$project = Project::factory()->create([
|
|
'tenant_id' => $tenant->id, 'daily_limit_target' => 50, 'delivered_today' => 30,
|
|
]);
|
|
|
|
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
|
|
'daily_limit_target' => 20,
|
|
])->assertStatus(422);
|
|
});
|
|
|
|
it('rejects update of signal_type (immutable)', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$user = User::factory()->create(['tenant_id' => $tenant->id]);
|
|
$project = Project::factory()->create(['tenant_id' => $tenant->id, 'signal_type' => 'site', 'signal_identifier' => 'test.ru']);
|
|
|
|
$response = $this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
|
|
'signal_type' => 'call',
|
|
]);
|
|
|
|
// signal_type должен быть проигнорирован (не падает 422, но и не меняется)
|
|
expect($project->fresh()->signal_type)->toBe('site');
|
|
});
|
|
|
|
it('cross-tenant update returns 404', function () {
|
|
$tenantA = Tenant::factory()->create();
|
|
$tenantB = Tenant::factory()->create();
|
|
$userA = User::factory()->create(['tenant_id' => $tenantA->id]);
|
|
$project = Project::factory()->create(['tenant_id' => $tenantB->id]);
|
|
|
|
$this->actingAs($userA)->patchJson("/api/projects/{$project->id}", [
|
|
'name' => 'hack',
|
|
])->assertStatus(404);
|
|
});
|
|
|
|
it('updates delivery_days_mask (region_mask now read-only — see regions[] tests below)', function () {
|
|
// Plan 6: region_mask/region_mode больше не клиент-controllable через UpdateProjectRequest
|
|
// (validation rules удалены, ProjectService::create dual-writes 255/include).
|
|
// Источник истины для региональной фильтрации — projects.regions INT[] (Plan 6).
|
|
// Этот тест адаптирован: проверяет, что delivery_days_mask остаётся writeable через PATCH.
|
|
$tenant = Tenant::factory()->create();
|
|
$user = User::factory()->create(['tenant_id' => $tenant->id]);
|
|
$project = Project::factory()->create(['tenant_id' => $tenant->id]);
|
|
|
|
$this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
|
|
'delivery_days_mask' => 31,
|
|
])->assertOk();
|
|
|
|
expect($project->fresh()->delivery_days_mask)->toBe(31);
|
|
});
|
|
|
|
// Plan 6 — subject-level regions[] support.
|
|
|
|
it('updates regions array via PATCH', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$user = User::factory()->create(['tenant_id' => $tenant->id]);
|
|
$project = Project::factory()->create(['tenant_id' => $tenant->id, 'regions' => []]);
|
|
|
|
$response = $this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
|
|
'regions' => [82],
|
|
]);
|
|
|
|
$response->assertStatus(200);
|
|
expect($project->fresh()->regions)->toBe([82]);
|
|
});
|
|
|
|
it('preserves regions when PATCH omits the field (sometimes rule)', function () {
|
|
$tenant = Tenant::factory()->create();
|
|
$user = User::factory()->create(['tenant_id' => $tenant->id]);
|
|
$project = Project::factory()->create([
|
|
'tenant_id' => $tenant->id,
|
|
'regions' => [82, 83],
|
|
]);
|
|
|
|
$response = $this->actingAs($user)->patchJson("/api/projects/{$project->id}", [
|
|
'name' => 'Renamed Project',
|
|
]);
|
|
|
|
$response->assertStatus(200);
|
|
expect($project->fresh()->regions)->toBe([82, 83]);
|
|
});
|