Дмитрий
a907fea031
Schema delta (4 правки в db/schema.sql):
- tenants + delivered_in_month INT NOT NULL DEFAULT 0 CHECK (>=0) — month
counter для PricingTierResolver O(1) lookup на горячем пути.
- lead_charges + charge_source VARCHAR(8) DEFAULT 'rub' CHECK IN ('prepaid','rub')
+ ALTER ADD CONSTRAINT chk_lead_charges_prepaid_zero_price (prepaid → price=0).
- supplier_leads + recovered_from_csv_at TIMESTAMPTZ + partial index
WHERE recovered_from_csv_at IS NOT NULL.
- Новая таблица supplier_csv_reconcile_log (SaaS-level, без RLS) + 2 индекса
(started_at DESC, partial status WHERE status IN ('drift_alert','failed')).
Метрики: 61 → 62 базовых таблиц / 114 → 117 индексов / 39 RLS (без изменений).
Сопутствующие правки:
- db/CHANGELOG_schema.md — v8.19 entry (18 записей).
- db/02_grants.sql — GRANT SELECT,INSERT,UPDATE on supplier_csv_reconcile_log
+ GRANT USAGE,SELECT on sequence для crm_supplier_worker.
- app/Models/Tenant — fillable+casts: delivered_in_month integer.
- app/Models/LeadCharge — fillable+casts: charge_source string.
- app/Models/SupplierLead — fillable+casts: recovered_from_csv_at datetime.
- LeadChargeFactory — defaults charge_source='rub' + prepaid() state.
- PricingTierSeeder (новый) — 7 ступеней дефолтного тарифа (placeholder,
Plan 4 Открытый вопрос #1: 100/200/400/800/1500/3000/∞ leads at
50000/45000/40000/35000/30000/27000/25000 копеек).
- DatabaseSeeder — call PricingTierSeeder; убран broken Laravel scaffold
User::factory(['name' => ...]) (наша схема first_name/last_name).
Tests (Plan 4 surface):
- SchemaDeltaTest.php — 5 it() блоков: delivered_in_month CHECK, charge_source
CHECK на prepaid+zero-price, recovered_from_csv_at колонка, reconcile_log
таблица+status CHECK, migrate:fresh idempotency (skip in parallel).
- pest --filter=SchemaDeltaTest: 5/5 PASS (9 assertions, 2076 ms).
- pest --filter='Tenant|LeadCharge|SupplierLead|Plan4': 111/111 PASS.
CI gates:
- composer pint: passed.
- composer stan: passed (0 errors above baseline — @phpstan-ignore-next-line
на $this->markTestSkipped в Pest closure rebound context).
Verify:
- migrate:fresh --seed на DB_DATABASE=liderra_testing: 0 errors, 754 ms.
- PricingTier::count() = 7.
Концерны (НЕ блокируют Task 1):
- pest --parallel: 617/622 PASS + 4 skipped + 1 flaky FAIL — flaky test
колеблется между ProjectExtensionsTest::supplierB1_B2_B3_relations
(SupplierProjectFactory race: closure пикает signal_type=sms до override
platform=B1 → CHECK chk_supplier_projects_b1_not_for_sms violation)
и NewLeadNotificationTest::webhook_дубль_Биз_19 (известный microsecond
precision quirk в anti-spam exclusion, memory feedback_environment.md).
Оба теста существуют на main (HEAD 0802f7c = plan4-billing branch HEAD
до этого commit'а), Plan 4 их не трогает. Фиксы — вне Task 1 scope.
Spec: docs/superpowers/specs/2026-05-11-plan4-billing-csv-admin-design.md §2.
Plan: docs/superpowers/plans/2026-05-11-plan4-billing-csv-admin-plan.md Task 1.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
71 lines
3.3 KiB
PHP
71 lines
3.3 KiB
PHP
<?php
|
||
|
||
declare(strict_types=1);
|
||
|
||
use App\Models\Deal;
|
||
use App\Models\Tenant;
|
||
use Illuminate\Database\QueryException;
|
||
use Illuminate\Support\Facades\Artisan;
|
||
use Illuminate\Support\Facades\DB;
|
||
use Illuminate\Support\Facades\Schema;
|
||
|
||
// NOTE: \Tests\TestCase auto-binds via tests/Pest.php (->in('Feature')); explicit
|
||
// uses(\Tests\TestCase::class) conflicts ("already uses the test case").
|
||
|
||
it('tenants table has delivered_in_month column with CHECK >= 0', function () {
|
||
expect(Schema::hasColumn('tenants', 'delivered_in_month'))->toBeTrue();
|
||
DB::table('tenants')->where('id', '<', 0)->update(['delivered_in_month' => 5]); // no-op
|
||
expect(fn () => DB::statement(
|
||
'INSERT INTO tenants (subdomain, organization_name, contact_email, webhook_token, delivered_in_month) '.
|
||
"VALUES ('t-neg-test', 'X', 'x@x', 'wtok-neg-test-99999999', -1)"
|
||
))->toThrow(QueryException::class);
|
||
});
|
||
|
||
it('lead_charges table has charge_source column with CHECK on prepaid=zero-price', function () {
|
||
expect(Schema::hasColumn('lead_charges', 'charge_source'))->toBeTrue();
|
||
$tenant = Tenant::factory()->create();
|
||
$deal = Deal::factory()->create(['tenant_id' => $tenant->id]);
|
||
expect(fn () => DB::table('lead_charges')->insert([
|
||
'tenant_id' => $tenant->id,
|
||
'deal_id' => $deal->id,
|
||
'deal_received_at' => $deal->received_at,
|
||
'tier_no' => 1,
|
||
'price_per_lead_kopecks' => 50000,
|
||
'charge_source' => 'prepaid',
|
||
'charged_at' => now(),
|
||
'created_at' => now(),
|
||
]))->toThrow(QueryException::class);
|
||
});
|
||
|
||
it('supplier_leads table has recovered_from_csv_at column', function () {
|
||
expect(Schema::hasColumn('supplier_leads', 'recovered_from_csv_at'))->toBeTrue();
|
||
});
|
||
|
||
it('supplier_csv_reconcile_log table exists with required columns and status CHECK', function () {
|
||
expect(Schema::hasTable('supplier_csv_reconcile_log'))->toBeTrue();
|
||
expect(Schema::hasColumns('supplier_csv_reconcile_log', [
|
||
'id', 'started_at', 'finished_at', 'window_start', 'window_end',
|
||
'total_csv_rows', 'matched_count', 'recovered_count', 'drift_ratio',
|
||
'status', 'error_message', 'alert_email_sent_at', 'created_at',
|
||
]))->toBeTrue();
|
||
expect(fn () => DB::table('supplier_csv_reconcile_log')->insert([
|
||
'started_at' => now(),
|
||
'window_start' => now()->subDay(),
|
||
'window_end' => now(),
|
||
'status' => 'unknown_status',
|
||
]))->toThrow(QueryException::class);
|
||
});
|
||
|
||
it('migrate:fresh is idempotent — re-run produces same metrics', function () {
|
||
// В parallel-режиме DROP CASCADE на главной БД конфликтует с воркерами;
|
||
// serial-проверку выполняем через `pest tests/.../SchemaDeltaTest.php` (Step 11).
|
||
if (getenv('LARAVEL_PARALLEL_TESTING')) {
|
||
// @phpstan-ignore-next-line method.notFound (Pest rebinds $this to TestCase at runtime)
|
||
$this->markTestSkipped('Idempotency check is serial-only (avoids cross-worker DROP CASCADE deadlock).');
|
||
}
|
||
$beforeTables = count(DB::select("SELECT tablename FROM pg_tables WHERE schemaname='public'"));
|
||
Artisan::call('migrate:fresh', ['--database' => 'pgsql', '--force' => true]);
|
||
$afterTables = count(DB::select("SELECT tablename FROM pg_tables WHERE schemaname='public'"));
|
||
expect($afterTables)->toBe($beforeTables);
|
||
});
|