Fix 1 (correctness): keywordOverlapCount dedupes `a` into a Set so duplicate
keywords like ['router','router','gate'] ∩ ['router','gate'] yields 2 not 3.
Fix 2 (consistency): deep-freeze all nested threshold objects in DEFAULT_THRESHOLDS
matching the tools/cost-pricing.mjs pattern.
Fix 3 (cleanup): move isMutatingForBaseline check to top of evaluateThresholds
so key/th vars are only computed in the metered-tool branch.
Fix 4 (coverage): add LS=10 and AskUserQuestion=2 soft_flag tests.
Fix 5 (docs): JSDoc on METERED_TOOLS noting TodoWrite → TodoWrite_writes mapping.
Tests: 23 → 29 (+6), all GREEN.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Two changes:
1. CONFIDENCE_THRESHOLD 0.8 → 0.6 — catches borderline recommendations
that previously slipped through. Driver: brain-retro #10 shows 0%
single-node-skill follow-through, suggesting hook needs to fire more.
2. Inline escape hatch — 'router-skip: <reason 50+ chars>' in assistant text.
Per-tool scope (does not affect other tools in same turn). Replaces
the documented 'override: <reason>' hint which was a self-bypass
loophole — high-friction 50+ char justification discourages reflexive use.
Per Level 2 of plan docs/superpowers/plans/2026-05-28-router-discipline-level-1-2.md.
Legacy tests flipped (2 tests):
- 'allows when confidence exactly 0.7 (raised threshold)' →
'BLOCKS when confidence exactly 0.7 (above new threshold 0.6)'
- 'allows when confidence 0.75 (still under raised threshold)' →
'BLOCKS when confidence 0.75 (above new threshold 0.6)'
These tests previously asserted block:false at 0.7/0.75 under the old 0.8
threshold; with 0.6 threshold they now correctly assert block:true.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Adds RATE_WINDOW_MIN=10 + RATE_THRESHOLD=5 alongside existing per-day THRESHOLD=5.
Closes gap where per-day limit doesn't catch rate-spikes:
- 2026-05-28 session 4a8b327e burned 40 events / 59 minutes (0.68/min).
- Per-day=5 was breached after 5 events; rate-spike of next 35 went uncounted.
shouldBlock returns triggered='daily' or 'rate' with reason. buildBlockOutput
emits rate-specific message asking for 10-min pause + bypass-phrase
confirmation.
Per Level 1 plan docs/superpowers/plans/2026-05-28-router-discipline-level-1-2.md.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reduces full-opt-out from 11→3 categories (tdd-gate / verify-before-commit /
verify-before-push). Requires_justification 'ремонт:' kept intact.
Driver: brain-retro #10 trend analysis — 'ремонт инфраструктуры' fired
26 times on 2026-05-28 (vs 71 on 27.05). Used as side-effect to bypass
classifier/chain/skill hooks. Per Level 1 plan.
Also flips test 'global override "ремонт инфраструктуры" suppresses semgrep-security'
to assert new behaviour (toBeFalsy) in tools/enforce-semgrep-security.test.mjs.
Old test asserted truthy — now ремонт инфраструктуры no longer suppresses semgrep-security.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Reduces 'recovery' suppresses 5→2 categories. Removes graph-first /
chain-recommendation / semgrep-security side-effects.
Driver: brain-retro #10 trend analysis — 'recovery' fired 525 times
on 2026-05-28 (vs 10/day baseline 25.05). Per Level 1 plan
docs/superpowers/plans/2026-05-28-router-discipline-level-1-2.md.
Also updates enforce-semgrep-security.test.mjs: flips the 'recovery'
suppresses-semgrep-security test to assert the new correct behaviour
(recovery does NOT suppress semgrep-security).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Code-quality review of Task B (Phase 4) flagged two minor fixes:
- Export CHAIN_OUTCOME_BUCKETS for external consumers (test + future cuts)
no longer hard-code bucket names.
- Replace fs.readFileSync via duplicate `import fs from 'fs'` with the
already-imported named `readFileSync` in helpers test.
+1 regression test on the export.
Workflow run 26564909645 failed: migration 2026_05_27_120000_create_project_routing_snapshots_table
hit 'SET ROLE crm_migrator' failure (pgsql conn = crm_app_user, not member of crm_migrator).
Failed SET ROLE poisoned transaction → subsequent CREATE TABLE failed SQLSTATE[25P02].
Fix in deploy.yml:
New step 'Pre-apply partitioned migrations via postgres superuser' runs CREATE TABLE
+ indexes + RLS + GRANTs + partitions + system_settings insert via sudo -u postgres psql,
then marks migration as ran in migrations table. Idempotent (checks both migrations
table AND information_schema). Established prod pattern (memory: paused_at migration 26.05).
Side fix in tools/enforce-override-limit.test.mjs:
CLI e2e tests used 'node tools/enforce-override-limit.mjs' without cwd, failed when
vitest ran from app/. Added cwd: projectRoot via fileURLToPath(import.meta.url).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Closes brain-retro #9 candidate 10 + self-retrospect 28.05: 16 reviewer-
Opus marks of "should have delegated to coder-agent". Controller (Opus)
was doing repetitive mechanical work itself, burning big-context budget
on tasks suited for fresh subagent.
PATTERN 8 trains classifier to recognize mechanical/repetitive signals
(N odnotipnyh, massovaya pravka, po shablonu) and recommend coder-agent
#19 via Task tool delegation.
Closes brain-retro #9 candidate 8: 8 reviewer-Opus marks of "should
have used Sentry first". Self-retrospect 28.05: "симптом с боевого →
гадать по коду вместо Sentry".
PATTERN 7 forces classifier to put Sentry MCP (#34) FIRST in
recommended_chain when prompt indicates production-runtime origin
(boevoj, klient soobschil, v logah, etc).
NB: Sentry MCP is currently pending B-1 deployment per Tooling section
4.8, but pattern is added so classifier produces correct recommendation
once instance is live.
Closes brain-retro #9 candidate 1: classifier recognized bugfix via
PATTERN 4 (→ systematic-debugging) but didn't extend to chain with
Pest #18 for test-first regression coverage.
Real-world driver: adr-judge.py catastrophic backtracking fix (commit
3dafeb15) — should have gone through TDD via Pest, not direct edit.
Reviewer Section A in retro #9 flagged this.
PATTERN 6 extends PATTERN 4 with explicit chain recommendation when
fix touches live code (regex/parser/hook/race/perf).
Verifies CLI exits cleanly on empty stdin and on prompt without override-
phrase. Block-JSON path is tested via the pure shouldBlock() function;
e2e CLI test confirms wiring without depending on per-machine JSONL state.
Code-review noted that any uncaught exception in main() would propagate
as a non-zero exit, potentially blocking the user. Plan required fail-
open discipline; sibling hooks (enforce-chain-recommendation) use the
same try/catch wrapper pattern.
Follow-up to c9127639.
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Adds tools/enforce-override-limit.mjs as PreToolUse hook implementing
hard-block on 6th+ usage of same override-phrase within one calendar day
(threshold 5 per-phrase). Bypass via «лимит снят» in current prompt
(one-shot, counter not reset).
Pure exports: countTodayUsage, findPhrasesInPrompt, shouldBlock,
buildBlockOutput, VOCAB, THRESHOLD, BYPASS_PHRASE.
Closes brain-retro #9 candidate 6 (logic only — hook registration in Task 2).
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Code review noted that the new section heading ## C6: System Health collided
with the existing alert-table row | C6 Chain map sync | for controller C6.
Two things named C6 confuses readers and brain-retro analysis scripts.
Heading is now ## System Health (no prefix). Section position unchanged.
Also tightens weak toContain('2')-style assertions in system-health.test.mjs
to pipe-delimited '| 2 |' form -- prevents false-passes if sort order breaks.
Follow-up to 7314a926.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Stale `docs/archive/llm-bootstrap-2026-05/routing-docs/observer-classification-map.json`
was being read inside Cuts 8/9/10 when classificationMap was empty.
Source of #37 mermaid noise in retro #9 deploy/monitoring missed-activations.
Analyzer now uses nodes.yaml-derived map exclusively (single SoT per ADR-016).
Also removed unused `pathResolve` import (was only used in fallback block).
Regression test added.
Closes brain-retro #9 candidate 3.
Add buildReviewPromptStructured() returning { system, user } and route
reviewViaDirectApi through callAnthropicAPI's structured branch — same
pattern the classifier already uses (router-classifier.mjs L456-484), so
infrastructure is reused, no new transport code.
system block: static instructions + 8-dim cues + schema-version notes
(byte-identical across episodes of the same schema_version → cache key
stable within a 5-min TTL).
user block: per-episode JSON (volatile).
Effect on Opus 4.7: ~zero until system grows past 4096-token cache-
minimum or model switches to Sonnet (2048 min). Anthropic silently
no-ops cache_control when prefix is below the minimum — no error,
cache_creation_input_tokens just stays at 0. Architecturally correct
and future-proof; activates the moment either condition flips.
buildReviewPrompt() kept as backward-compat wrapper.
Tests: +5 invariants for the split + cache-prerequisite check
(system identical across two v4 episodes with different bodies).
14/14 GREEN.
ремонт: фикс инфраструктуры стоимости — split prompt для активации
prompt caching на reviewer-agent
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Closes third behavioral-debt block from retro #8: CLAUDE.md §5 п.14 (graph-first для codebase-вопросов) was being ignored — controller did 4+ Grep searches today without consulting graphify.
Three changes:
1. tools/enforce-graph-first.mjs (NEW): Stop hook blocking turn-end when Grep+Glob count >= 3 in turn AND no graphify invocation (Skill 'graphifyy' / Bash 'graphifyy' / SlashCommand 'graphify'). Override: 'graph-skip: <reason>' inline OR global override-phrase. 19 vitest tests cover empty toolUses, threshold boundary, graphify detection forms, override variants.
2. tools/enforce-override-vocab.json: added 'graph-first' AND 'chain-recommendation' to suppresses[] of all 7 global override phrases (без скилов / direct ok / срочно / быстрый коммит / recovery / memory dump / ремонт инфраструктуры). This closes a vocab gap that ALSO affected the previously-deployed chain-recommendation hook (a3 from dbaf0e0e) — global overrides did not work for it either until now.
3. .claude/settings.json: registered enforce-graph-first.mjs as 5th Stop hook entry.
Full vitest tools-sweep: 1041/1041 GREEN. Reviewer APPROVE on spec + code quality. Pipe-test verified (empty event → exit 0, no block).
Дмитрий