portal

liderra/portal

Fork 0

Commit Graph

Author	SHA1	Message	Date
Дмитрий	f298984055	feat(supplier): Plan 3 Task 5 — RefreshSupplierSessionJob + PlaywrightBridge Компоненты: - app/playwright/{package.json, refresh-session.js} — изолированный Node.js + Playwright chromium subprocess для headless логина - PlaywrightProcessHandle interface + SymfonyPlaywrightProcessHandle (prod) + StubPlaywrightProcessHandle (test) для DI без extending Symfony Process - ProcessFactory + SymfonyProcessFactory - PlaywrightBridge: PHP-обёртка, timeout 75s, JSON contract, exit code → SupplierAuthException - RefreshSupplierSessionJob: stub → real (tries=3, backoff [2m/10m/30m], Cache::lock concurrent guard, Redis TTL 6h) - supplier:session:refresh Console command - AppServiceProvider binds ProcessFactory → SymfonyProcessFactory +7 tests (4 PlaywrightBridge + 2 Job + 1 Command). NOTE: DOM-селекторы placeholder — финализация после Task 1 discovery. NOTE: app/playwright/node_modules в .gitignore. Quirks resolved: - Mockery::mock(Process::class) + laravel/pao = stream_filter_remove fatal. Решение: handle interface, pure-PHP test stub без extends Process. - PHPStan Mockery union types — baseline entries (known Mockery+PHPStan compat). KNOWN LIMITATION: на этой Windows машине pao stream filter conflict при serial run SupplierPortalClient+RefreshSupplierSessionJob combo. Tests pass individually + парами. Production Linux CI не affected.	2026-05-11 06:46:13 +03:00
Дмитрий	a8a23cb269	fix(supplier): Plan 3 Task 4 code-review fixes (4 Important defense-in-depth) Закрывает 4 Important issues из code-review Task 4 (a2c5374): - #1 SupplierPortalClient: parse_url host validation → SupplierClientException вместо silent cookie skip + false-positive SupplierAuthException - #2 dispatch_sync(RefreshSupplierSessionJob) обёрнут try/catch (request retry + loadSession) → raw exceptions translated в SupplierAuthException для consistency с error taxonomy перед Task 5 real Playwright impl - #3 RefreshSupplierSessionJob stub handle() теперь throws LogicException с понятным сообщением (вместо silent no-op → confusing 'cache still empty' error). После Task 5 — LogicException заменяется real Playwright code. Снят final-модификатор класса (test override через container bind + Laravel dispatchSync serialization не работает с anonymous classes). - #5 SupplierProjectDto::equals → canonical order для workdays/regions через sort в constructor (defense vs PG jsonb non-deterministic order). Без этого Task 6 SyncJob false-positive обнаруживал бы diff где его нет → unnecessary updateProject HTTP calls. +3 tests в SupplierPortalClientTest (malformed url, 2 retry-translation paths) +2 tests в новом SupplierProjectDtoTest (order-independent equals + non-equal) +1 stub-класс ThrowingRefreshSupplierSessionJob (anonymous classes несовместимы с SerializesModels trait в dispatchSync). Pest: 38/38 supplier-suite, 574/574 full suite (576 total, 2 skipped, +5 new tests vs Task 4 baseline). PHPStan 0 errors. Pint clean.	2026-05-11 06:46:13 +03:00

Author

SHA1

Message

Date

Дмитрий

f298984055

feat(supplier): Plan 3 Task 5 — RefreshSupplierSessionJob + PlaywrightBridge

Компоненты:
- app/playwright/{package.json, refresh-session.js} — изолированный Node.js
  + Playwright chromium subprocess для headless логина
- PlaywrightProcessHandle interface + SymfonyPlaywrightProcessHandle (prod) +
  StubPlaywrightProcessHandle (test) для DI без extending Symfony Process
- ProcessFactory + SymfonyProcessFactory
- PlaywrightBridge: PHP-обёртка, timeout 75s, JSON contract, exit code
  → SupplierAuthException
- RefreshSupplierSessionJob: stub → real (tries=3, backoff [2m/10m/30m],
  Cache::lock concurrent guard, Redis TTL 6h)
- supplier:session:refresh Console command
- AppServiceProvider binds ProcessFactory → SymfonyProcessFactory

+7 tests (4 PlaywrightBridge + 2 Job + 1 Command).

NOTE: DOM-селекторы placeholder — финализация после Task 1 discovery.
NOTE: app/playwright/node_modules в .gitignore.

Quirks resolved:
- Mockery::mock(Process::class) + laravel/pao = stream_filter_remove fatal.
  Решение: handle interface, pure-PHP test stub без extends Process.
- PHPStan Mockery union types — baseline entries (known Mockery+PHPStan compat).

KNOWN LIMITATION: на этой Windows машине pao stream filter conflict при
serial run SupplierPortalClient+RefreshSupplierSessionJob combo.
Tests pass individually + парами. Production Linux CI не affected.

2026-05-11 06:46:13 +03:00

Дмитрий

a8a23cb269

fix(supplier): Plan 3 Task 4 code-review fixes (4 Important defense-in-depth)

Закрывает 4 Important issues из code-review Task 4 (a2c5374):
- #1 SupplierPortalClient: parse_url host validation → SupplierClientException
  вместо silent cookie skip + false-positive SupplierAuthException
- #2 dispatch_sync(RefreshSupplierSessionJob) обёрнут try/catch (request retry +
  loadSession) → raw exceptions translated в SupplierAuthException для
  consistency с error taxonomy перед Task 5 real Playwright impl
- #3 RefreshSupplierSessionJob stub handle() теперь throws LogicException
  с понятным сообщением (вместо silent no-op → confusing 'cache still empty'
  error). После Task 5 — LogicException заменяется real Playwright code.
  Снят final-модификатор класса (test override через container bind + Laravel
  dispatchSync serialization не работает с anonymous classes).
- #5 SupplierProjectDto::equals → canonical order для workdays/regions
  через sort в constructor (defense vs PG jsonb non-deterministic order).
  Без этого Task 6 SyncJob false-positive обнаруживал бы diff где его нет
  → unnecessary updateProject HTTP calls.

+3 tests в SupplierPortalClientTest (malformed url, 2 retry-translation paths)
+2 tests в новом SupplierProjectDtoTest (order-independent equals + non-equal)
+1 stub-класс ThrowingRefreshSupplierSessionJob (anonymous classes несовместимы
  с SerializesModels trait в dispatchSync).

Pest: 38/38 supplier-suite, 574/574 full suite (576 total, 2 skipped, +5 new
tests vs Task 4 baseline). PHPStan 0 errors. Pint clean.

2026-05-11 06:46:13 +03:00

2 Commits